Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify strides #194

Merged
merged 3 commits into from
Nov 23, 2023
Merged

refactor: simplify strides #194

merged 3 commits into from
Nov 23, 2023

Conversation

tlambert03
Copy link
Owner

small refactor to simplify strides during read

@tlambert03 tlambert03 marked this pull request as ready for review November 21, 2023 20:46
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdf0ecb) 95.43% compared to head (0efd76d) 95.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          17       17           
  Lines        2346     2346           
=======================================
  Hits         2239     2239           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 21, 2023

CodSpeed Performance Report

Merging #194 will not alter performance

Comparing simplify-strides (0efd76d) with main (bdf0ecb)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 merged commit eb4bf8f into main Nov 23, 2023
21 checks passed
@tlambert03 tlambert03 deleted the simplify-strides branch November 23, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant