-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hacky fix for files with subloops #193
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 95.49% 95.16% -0.33%
==========================================
Files 17 17
Lines 2308 2318 +10
==========================================
+ Hits 2204 2206 +2
- Misses 104 112 +8 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #193 will not alter performanceComparing Summary
|
Hi Talley, Just to let you know that you did a fantastic job and this branch works really well with the paused acquisitions, so I'd be happy to see it merged into production. Let me know if you need something before this happens. Best |
Thanks @aaristov. I did end up getting some feedback from the folks at Laboratory Imaging, so I have a bit more info now on how to "properly" handle this unusual case. But, that proper way is even more convoluted 😂 hence my delay. But, if this is better than nothing, and you'd like to see it in, perhaps I'll just cut a release with this version, and then make more robust in a follow up. |
This is a proof-of-principle hacky fix for the file that @aaristov shared in #190
@aaristov, if you're inclined, feel free to check out this branch and see if it works for you. I won't be merging this until I understand a bit better how that file ended up with this structure.
closes #190