Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use common base class for legacy and modern reader, move logic from nd2file #160

Merged
merged 10 commits into from
Jul 9, 2023

fix coverage

cba6f9b
Select commit
Loading
Failed to load commit list.
Merged

refactor: use common base class for legacy and modern reader, move logic from nd2file #160

fix coverage
cba6f9b
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch failed Jul 9, 2023 in 1s

91.42% of diff hit (target 93.66%)

View this Pull Request on Codecov

91.42% of diff hit (target 93.66%)

Annotations

Check warning on line 152 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L152 

Added line #L152 was not covered by tests

Check warning on line 164 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L164 

Added line #L164 was not covered by tests

Check warning on line 274 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L274 

Added line #L274 was not covered by tests

Check warning on line 289 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L288-L289 

Added lines #L288 - L289 were not covered by tests

Check warning on line 313 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L313 

Added line #L313 was not covered by tests

Check warning on line 317 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L315-L317 

Added lines #L315 - L317 were not covered by tests

Check warning on line 339 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L339 

Added line #L339 was not covered by tests

Check warning on line 350 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L350 

Added line #L350 was not covered by tests

Check warning on line 354 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L354 

Added line #L354 was not covered by tests

Check warning on line 363 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L363 

Added line #L363 was not covered by tests

Check warning on line 368 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L367-L368 

Added lines #L367 - L368 were not covered by tests

Check warning on line 398 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L397-L398 

Added lines #L397 - L398 were not covered by tests

Check warning on line 404 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L403-L404 

Added lines #L403 - L404 were not covered by tests

Check warning on line 417 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L416-L417 

Added lines #L416 - L417 were not covered by tests

Check warning on line 421 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L421 

Added line #L421 was not covered by tests

Check warning on line 445 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L445 

Added line #L445 was not covered by tests

Check warning on line 467 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L467 

Added line #L467 was not covered by tests

Check warning on line 513 in src/nd2/readers/_legacy/legacy_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_legacy/legacy_reader.py#L513 

Added line #L513 was not covered by tests

Check warning on line 643 in src/nd2/readers/_modern/modern_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_modern/modern_reader.py#L640-L643 

Added lines #L640 - L643 were not covered by tests

Check warning on line 646 in src/nd2/readers/_modern/modern_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_modern/modern_reader.py#L645-L646 

Added lines #L645 - L646 were not covered by tests

Check warning on line 648 in src/nd2/readers/_modern/modern_reader.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/_modern/modern_reader.py#L648 

Added line #L648 was not covered by tests

Check warning on line 60 in src/nd2/readers/protocol.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/protocol.py#L60 

Added line #L60 was not covered by tests

Check warning on line 107 in src/nd2/readers/protocol.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/protocol.py#L106-L107 

Added lines #L106 - L107 were not covered by tests

Check warning on line 111 in src/nd2/readers/protocol.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/protocol.py#L111 

Added line #L111 was not covered by tests

Check warning on line 151 in src/nd2/readers/protocol.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/nd2/readers/protocol.py#L151 

Added line #L151 was not covered by tests
View more details on Codecov