Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ome_metadata output to ome-types #153

Merged
merged 13 commits into from
Jul 4, 2023
Merged

feat: add ome_metadata output to ome-types #153

merged 13 commits into from
Jul 4, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Jul 3, 2023

A start to support ome-metadata output

with nd2.ND2File('myfile.nd2') as f:
    ome = f.ome_metadata()  # instance of ome_types.OME

# then to get xml.....
ome.to_xml()

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2023

CodSpeed Performance Report

Merging #153 will not alter performances

Comparing ome (4f79fa2) with main (c0f1c78)

Summary

✅ 13 untouched benchmarks

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #153 (4f79fa2) into main (c0f1c78) will increase coverage by 0.21%.
The diff coverage is 98.11%.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   93.28%   93.49%   +0.21%     
==========================================
  Files          15       16       +1     
  Lines        2220     2261      +41     
==========================================
+ Hits         2071     2114      +43     
+ Misses        149      147       -2     
Impacted Files Coverage Δ
src/nd2/__init__.py 100.00% <ø> (ø)
src/nd2/_pysdk/_parse.py 93.77% <ø> (+0.28%) ⬆️
src/nd2/_ome.py 97.72% <97.72%> (ø)
src/nd2/_clx_xml.py 89.36% <100.00%> (ø)
src/nd2/_legacy/_legacy_xml.py 97.50% <100.00%> (ø)
src/nd2/_pysdk/_pysdk.py 91.79% <100.00%> (+0.34%) ⬆️
src/nd2/nd2file.py 95.55% <100.00%> (+0.02%) ⬆️
src/nd2/structures.py 96.08% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 merged commit 81e47b2 into main Jul 4, 2023
@tlambert03 tlambert03 deleted the ome branch July 4, 2023 17:51
@tlambert03 tlambert03 added the enhancement New feature or request label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant