-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch exception on file open and release handle #117
Conversation
hmm.. getting lots of segfaults in tests here, and can reproduce locally too |
had to use a different approach in the |
No. This latest commit leaves the file handle open. Specifically, the line |
oh right of course 🤦♂️ sorry!
don't want to assert that compressionType is always there ... but i can check that attributes is at least length 6 i updated again... when you have a moment |
Yes, this most recent version works. I get "Unknown error reading attributes in file" and the file handle is properly closed. |
Excellent. Thanks again for your time. Much appreciated |
fixes #114
@manthey ... this look good?