Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close handles on object deletion #116

Merged
merged 2 commits into from
Dec 8, 2022
Merged

fix: close handles on object deletion #116

merged 2 commits into from
Dec 8, 2022

Conversation

tlambert03
Copy link
Owner

This closes an underlying file handle on object deletion (with a warning) in the case where the file is left open.

partial fix for #114 ... (though I haven't yet been able to check whether this solves the case of an exception on file open)

@tlambert03 tlambert03 merged commit bbd914b into main Dec 8, 2022
@tlambert03 tlambert03 deleted the close-on-del branch December 8, 2022 00:06
@tlambert03 tlambert03 added the bug Something isn't working label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant