#1596 making status icon accessible #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushyamig
commented
Aug 29, 2024
| @@ -527,7 +527,7 @@ function AssignmentTable (props) { | |||
| </TableCell> | |||
| <TableCell className={classes.veryNarrowCell}> | |||
| <Tooltip title={a.graded ? assignmentStatus.GRADED : a.submitted ? assignmentStatus.SUBMITTED : assignmentStatus.UNSUBMITTED}> | |||
| {a.graded ? <GradedIcon className={classes.graded} /> : a.submitted ? <SubmittedIcon className={classes.ungraded} /> : <UnsubmittedIcon className={classes.unsubmitted} />} | |||
| {a.graded ? <GradedIcon className={classes.graded} titleAccess='Graded' /> : a.submitted ? <SubmittedIcon className={classes.ungraded} titleAccess='Pending Grade' /> : <UnsubmittedIcon className={classes.unsubmitted} titleAccess='Unsubmitted'/>} | |||
| </Tooltip> | |||
There was a problem hiding this comment.
https://v5.mui.com/material-ui/api/svg-icon/
adding titleAccess removes aria-hidden attribute
|
This PR is ready for review |
jaydonkrooss
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1596
if you test this with VO it is not voiced the icon. But I talked with Gonzalo and he checked with NVDA sees to be voicing the label. So he likes the change. (I avoided testing in screen readers since accessibility team don't recommends it)
YNice.mov