Added autoFetchWalletKitConfig and fixed manual refreshing

[amircheikh]

Summary & Motivation

• Added autoFetchWalletKitConfig option to the TurnkeyProvider config. Setting this to false will disable the initial walletKitConfig fetch, saving on initialization time. If this is disabled and you want to use the handleLogin modal with Turnkey's Auth Proxy, you must pass in the enabled auth methods manually into the TurnkeyProvider config.

• Fixed refreshWallets and refreshUser not working when autoRefreshManagedState is disabled.

How I Tested These Changes

with-sdk-js and react-wallet-kit examples

Did you add a changeset?

yes

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f22b75f:

Sandbox	Source
@turnkey/example-react-components	Configuration

[moeodeh3]

all comments apply for both RN and React. This is okay for now until we restructure our config :)

[moeodeh3]

this can simplify, also worth commenting when its enabled or disabled:

 // if there is no authProxyConfigId or if autoFetchWalletKitConfig is specifically
 // set to false, we don't need to fetch the config
const shouldFetchWalletKitConfig =
    !!config.authProxyConfigId &&
    (config.autoFetchWalletKitConfig ?? true);

[amircheikh]

I can do this since I want empty string to be treated as null too:

const shouldFetchWalletKitConfig =
  config.authProxyConfigId != null &&
  config.authProxyConfigId !== "" &&
  (config.autoFetchWalletKitConfig !== false);

[moeodeh3]

I think both treat "" as nullish (false)

[moeodeh3]

instead of adding this in a condition in each if statement its probably cleaner to extract it out into its own if statement:

if (shouldFetchWalletKitConfig) {
      if (config.auth?.sessionExpirationSeconds) {
        console.warn(
          "Turnkey SDK warning. You have set sessionExpirationSeconds directly in the TurnkeyProvider. This setting will be ignored because you are using an auth proxy. Please configure session expiration in the Turnkey dashboard.",
        );
      }
      if (config.auth?.otpAlphanumeric !== undefined) {
        console.warn(
          "Turnkey SDK warning. You have set otpAlphanumeric directly in the TurnkeyProvider. This setting will be ignored because you are using an auth proxy. Please configure OTP settings in the Turnkey dashboard.",
        );
      }
      if (config.auth?.otpLength) {
        console.warn(
          "Turnkey SDK warning. You have set otpLength directly in the TurnkeyProvider. This setting will be ignored because you are using an auth proxy. Please configure OTP settings in the Turnkey dashboard.",
        );
      }
    }

[moeodeh3]

I’m a bit confused about why we need to check shouldFetchWalletKitConfig at all

this actually makes me question the purpose of shouldFetchWalletKitConfig in buildConfig(). We shouldn’t need to check that flag here - why not treat the presence or absence of authProxyConfig as the source of truth?

if fetching is disabled, we simply keep authProxyConfig as undefined. When we call buildConfig(), it receives undefined, and that alone should tell us the fetch was skipped. No extra conditional needed

given that, instead of doing something like:

sessionExpirationSeconds: shouldFetchWalletKitConfig
  ? proxyAuthConfig?.sessionExpirationSeconds
  : config.auth?.sessionExpirationSeconds

we could instead do this:

sessionExpirationSeconds:
  proxyAuthConfig?.sessionExpirationSeconds ??
  config.auth?.sessionExpirationSeconds

[moeodeh3]

hmm I see you define shouldFetchWalletKitConfig as a global var - I think we should only use this locally in fetchProxyAuthConfig() and make buildConfig()just use whether the config is defined or not

[amircheikh]

cant define locally. used in "re-build" useEffect too

[moeodeh3]

nit: weird placement of a comment here - can we just have an internal comment header to follow our convention?

[moeodeh3]

same thing here

[moeodeh3]

this ones is a mb - but can we remove this 🙏