add attest and eph key #571
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
reviewed
Aug 8, 2025
| let bytes = | ||
| fs::read(attestation_doc_path).map_err(|e| Error::ReadShare(e.to_string()))?; | ||
| let attestation_doc: AttestationDoc = extract_attestation_doc(bytes.as_ref(), true, None); | ||
| let ephemeral_key: P256Public = P256Public::from_bytes(&attestation_doc.public_key.expect("No ephemeral key in the attestation doc"),).expect("Ephemeral key not valid public key"); |
There was a problem hiding this comment.
Just a note for the future if anyone ever wants to cleanup the CLI - the code is super inconsistent on when it chooses to panic vs bubble up an error. The expects are easier to write but probably better practice to bubble up an error. The issue is we don't use any error handling libraries so the error enum stuff is very unergonomic. If we didn't care about supply chain stuff I would suggest using anyhow or eyre. They are super popular and allow you to mix declaring error messages in place and using enums
https://docs.rs/anyhow/latest/anyhow/
https://docs.rs/eyre/latest/eyre/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
How I Tested These Changes
Pre merge check list