Remove probability of collision in connection IDs by switching to u128 in Proxy
#536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isions irrelevant
|
Good point @james-callahan, I've switched to u128 and brought back random connection ID assignment. Don't think we're concerned about the extra memory here. I've kept the vec->hashmap move because it gets us constant-time lookups. |
r-n-o
changed the title
Proxyu128 in Proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
There's a non-insignificant probability that connection IDs collide (~0.003%) given the current space is$2^{32}$ ) sized. Moving to
u32::MAX(u128to make this irrelevant.This was an informational-level finding by Trail of Bits during their last audit of this codebase.
How I Tested These Changes
Existing coverage