added client signature functionality #55
Conversation
moeodeh3
left a comment
moeodeh3
left a comment
There was a problem hiding this comment.
looks great - just some small nits, really appreciate you taking this on 🐐
| packages: | ||
| stamper: patch | ||
| changelog: |- | ||
| Added a `sign` function to the Api Key Stamper for signing client signatures and such. |
There was a problem hiding this comment.
Added a sign function to the API Key Stamper for signing arbitrary payloads
| http: patch | ||
| types: patch | ||
| changelog: |- | ||
| Synced `types` and `http client` with v2025.12.2 of `mono` |
There was a problem hiding this comment.
Synced com.turnkey.types and com.turnkey.http with v2025.12.2 of mono
| } | ||
| } | ||
|
|
||
| fun decodeVerificationToken(verificationToken: String): VerificationToken { |
There was a problem hiding this comment.
I feel like these should be public methods, not internal
if someone wants to use their own backend and generate client signatures themselves, these functions would make that much easier!
There was a problem hiding this comment.
The internal directory doesn't really mean anything in Kotlin, the method is still public for anyone to use so shouldn't be an issue.
There was a problem hiding this comment.
okay sweet - however, this is a bit misleading for readers. Eventually we should restructure this to clearly separate internal vs. public
that said, this is out of scope for this PR, so I’m going to mark it as resolved
| } | ||
| } | ||
|
|
||
| fun decodeVerificationToken(verificationToken: String): VerificationToken { |
There was a problem hiding this comment.
okay sweet - however, this is a bit misleading for readers. Eventually we should restructure this to clearly separate internal vs. public
that said, this is out of scope for this PR, so I’m going to mark it as resolved
No description provided.