Skip to content

Revert "feat(platform): proxy cluster version api" #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Revert "feat(platform): proxy cluster version api" #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/apiserver/filter/authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ var (
"/metrics",
"/debug",
"/openapi",
"/version",
"/swagger",
"/favicon.ico",
"/healthz",
Expand Down
9 changes: 9 additions & 0 deletions pkg/apiserver/openapi/openapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"strings"

"github.com/go-openapi/spec"
"k8s.io/apimachinery/pkg/version"
openapinamer "k8s.io/apiserver/pkg/endpoints/openapi"
genericapiserver "k8s.io/apiserver/pkg/server"
openapicommon "k8s.io/kube-openapi/pkg/common"
Expand All @@ -43,6 +44,14 @@ func SetupOpenAPI(genericAPIServerConfig *genericapiserver.Config, getDefinition
genericAPIServerConfig.OpenAPIConfig.Info.Version = appVersion.GitVersion
genericAPIServerConfig.OpenAPIConfig.PostProcessSpec = postProcessOpenAPISpec(host, port)

// version
genericAPIServerConfig.Version = &version.Info{
GitVersion: appVersion.GitVersion,
BuildDate: appVersion.BuildDate,
GoVersion: appVersion.GoVersion,
Compiler: appVersion.Compiler,
Platform: appVersion.Platform,
}
}

func postProcessOpenAPISpec(host string, port int) func(*spec.Swagger) (*spec.Swagger, error) {
Expand Down
5 changes: 0 additions & 5 deletions pkg/platform/apiserver/apiserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ import (
schedulingrest "tkestack.io/tke/pkg/platform/proxy/scheduling/rest"
settingsrest "tkestack.io/tke/pkg/platform/proxy/settings/rest"
storagerest "tkestack.io/tke/pkg/platform/proxy/storage/rest"
versionrest "tkestack.io/tke/pkg/platform/proxy/version/rest"
platformrest "tkestack.io/tke/pkg/platform/registry/rest"
"tkestack.io/tke/pkg/util/log"
)
Expand Down Expand Up @@ -204,10 +203,6 @@ func (m *APIServer) InstallAPIs(apiResourceConfigSource serverstorage.APIResourc
apiGroupsInfo = append(apiGroupsInfo, apiGroupInfo)
}

// install /version route
versionHandler := versionrest.NewVersionProxyHandler(m.GenericAPIServer.LoopbackClientConfig)
versionHandler.Install(m.GenericAPIServer.Handler.GoRestfulContainer)

for i := range apiGroupsInfo {
if err := m.GenericAPIServer.InstallAPIGroup(&apiGroupsInfo[i]); err != nil {
log.Fatalf("Error in registering group versions: %v", err)
Expand Down
72 changes: 0 additions & 72 deletions pkg/platform/proxy/version/rest/rest.go
View file
Open in desktop

This file was deleted.