fix(platform): delete machine failed & move machine operation to provider #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoryu
changed the title
TomatoAres
changed the title
Contributor
Author
|
We decide to move After modified codes by design, we meet a new question:
After I delete this judgment， we will meet a new error:
So we need some discussion next weekdays. |
TomatoAres
force-pushed
the
fix-1351
branch
2 times, most recently
from
b0d7c0d to
66ec962
Compare
Collaborator
|
LGTM |
pavlelee
approved these changes
Aug 3, 2021
| log.FromContext(ctx).Infof("delete machine %s failed.", machine.Name) | ||
| return err | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
if machine not found, should return nil to break
| if !errors.IsNotFound(err) { | ||
| return err | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
if node not found, should return nil to break
leoryu
added a commit
that referenced
this pull request
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fix tke can't delete machine when delete its cluster.
Which issue(s) this PR fixes:
Fixes #1351