feat(platform): proxy cluster version api #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxiaoliang
reviewed
Mar 19, 2021
| client, err := proxy.ClientSet(req.Request.Context(), platformClient) | ||
| if err != nil { | ||
| resp.WriteHeaderAndEntity(http.StatusBadRequest, "err1"+err.Error()) | ||
| return |
Contributor
There was a problem hiding this comment.
why err1 rather than "err.Error()"
Contributor
There was a problem hiding this comment.
to keep compatibility, please add logic to check if token or client crt/key pass to back-end, then proxy the request to remote k8s server, otherwise get version info from local
huxiaoliang
reviewed
Mar 19, 2021
|
|
||
| if err != nil { | ||
| resp.WriteHeaderAndEntity(http.StatusInternalServerError, "err2"+err.Error()) | ||
| return |
huxiaoliang
reviewed
Mar 19, 2021
| @@ -0,0 +1,51 @@ | |||
| package apiserver | |||
|
|
|||
Contributor
There was a problem hiding this comment.
- please place and rename this file to tke/pkg/platform/proxy/version/rest/storage.go
- add some comments to highlight this new feature: how to add new rest api which doesn't belong to native k8s resouce to tke-platform-api
- xx
- yy
Contributor
|
please fix CI build issue |
leoryu
force-pushed
the
proxy_version_api
branch
from
b412bb1 to
5fc64a1
Compare
pavlelee
pushed a commit
to GaoXiaodong/tke
that referenced
this pull request
Sep 6, 2021
This reverts commit ea282b5.
leoryu
added a commit
that referenced
this pull request
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix #1134
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: