Fix change directory issue #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we remove GetResultPath completely? |
|
@vors Yeah, I think it could make sense to remove |
|
Looks good to me. |
|
Added a test for parsing an invalid weight and changed the implementation to use Kept the |
|
@jensandresen can you, please, link email jad@trifork.com that you used for commits to your github profile? So we can have you in contributors :) |
This was referenced Sep 22, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed failing unit test regarding parsing a decimal (properly only an issue with a non English environment setup - mine being a Danish which resulted in a failing unit test right from the get-go).
Tip: always read and write decimal values (and other values which are different from culture to culture) as culture invariant to and from your persistence of choice.
Changed the call to ChangeDirectory to use the path of the best fitted record directly, because it would be enclosed in quotes in ChangeDirectory anyway. Also added a trim of the path string.