Skip to content
This repository was archived by the owner on Mar 5, 2020. It is now read-only.

Conversation

@rotty3000
Copy link

No description provided.

@tjwatson
Copy link
Owner

tjwatson commented Nov 5, 2018

I merged the m2e and asm updates, thanks! I think we should probably start a feature branch for the use of bnd 4.2.0 SNAPSHOT module support. Even when we get that work released in bnd I think we will want to have tests that have existing module-info.java and test that get it generated.

I did find an issue with the service.impl.activator module-info.class generation. It is not generating an open module so the framework is failing to construct the activator class. For now we are going to have to either make the test module open or perhaps just open the packages that contain the Bundle-Activator class.

Another issue is this approach makes running the JUnit test from Eclipse fail because m2e does something special if it knows the project is a module. It somehow sets up the module path correctly with all the compiled classes folders etc. But with no module-info.java file it appears to run the test from a normal class path which causes it to fail.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants