Skip to content

Commit

Permalink
server: Switch back to random scheduler to improve resilience to watc…
Browse files Browse the repository at this point in the history
…h starvation

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
  • Loading branch information
serathius authored and tjungblu committed Jul 26, 2023
1 parent 35dc790 commit 6f5e8c8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions server/embed/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ func configureHttpServer(srv *http.Server, cfg config.ServerConfig) error {
// todo (ahrtr): should we support configuring other parameters in the future as well?
return http2.ConfigureServer(srv, &http2.Server{
MaxConcurrentStreams: cfg.MaxConcurrentStreams,
// Override to avoid using priority scheduler which is affected by https://github.com/golang/go/issues/58804.
NewWriteScheduler: http2.NewRandomWriteScheduler,
})
}

Expand Down

0 comments on commit 6f5e8c8

Please sign in to comment.