fix: await re-creating player before updating video #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cfe657d:
|
ruisaraiva19
approved these changes
Jun 19, 2022
|
@ashphy no reason for not using async/await. Thanks for the pull request. |
|
🎉 This PR is included in version react-youtube-v9.0.2-canary.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version react-youtube-v9.0.3-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version react-youtube-v9.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
videoIdis changed,resetPlayerandupdateVideowill be called in order.However, because it doesn't wait for the
resetPlayer(asynchronous method),loadVideoByIdinupdateVideowill be called before the new player creates. It causes null access.Is there any reason not to use async/await? If so, I'll rewrite it with Promise.