Why does the player reset when only the dimensions have changed?

[dancancro]

If I pass in opts.width and opts.height, and they change while the player is playing, the player completely resets. I modified the code to keep this from happening and it works fine. Was there some rationale behind having it work this way?

[ruisaraiva19]

@dancancro I don't think there is a rationale behind having opts.width and opts.height triggering a player reset. @tjallingt please let us know if you disagree.

@dancancro Can you open a PR with this small change 🙏 ?

[tjallingt]

If we can avoid resetting we definitely should, probably never encountered this issue because I usually set width and height to 100%

[dancancro]

I can do a pull request but I'm stuck. My editor, VSCode, is removing spaces after "if"s and "switch"es. How do I get my editor, VSCode, to not automatically apply eslint fixes on save? This code in .vscode/settings.json isn't doing it...

{
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": false
  }
}

[ruisaraiva19]

@dancancro you can save changes without formating your code by running the VSCode command called File: Save without Formatting.

[dancancro]

I don't know how to run a VSCode command. I see menus and menu items that I can click. I don't see a menu item for saving without formatting.

[ruisaraiva19]

You can run "Command + Shift + P" to open the Command Palette and type "save without" until you see "File: Save without Formatting" command and use that.

[dancancro]

How do I fix this pull request? It's complaining about the format of the commit message of a previous commit.

[github-actions]

🎉 This issue has been resolved in version 7.13.1-canary.3 🎉

The release is available on:

• GitHub release
• npm package (@canary dist-tag)

Your semantic-release bot 📦🚀