Add compatibility with older node versions #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, that's not a good tradeoff for me. This adds risk and complication to the current version of the library for very very old versions of node.js! Let's continue discussion on #45 but I think simply this Pull Request I am going to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
buffer-fromponyfill forBuffer.fromandsafe-compareforcrypto.timingSafeEqual. I tested it on Node 0.10.48 and 18.x locally on my Windows machine, and the tests passed. The last test was not passing though on Node 0.10.48. It could be something to do with the Uint8Array implementation on that node version. It gaveTypeError: Not a bufferso I might have altered the test 😁.I know it's 2 more dependencies, I hope that's not inconvenient.