Merge pull request #305 from jaysonpotter/compile-underscore-partials

Partials Underscore Compile
tj · Mar 19, 2018 · 5480139 · 5480139
2 parents 4e05c88 + f9a1790
commit 5480139
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 2 deletions.
diff --git a/lib/consolidate.js b/lib/consolidate.js
@@ -901,6 +901,9 @@ exports.underscore.render = function(str, options, fn) {
   return promisify(fn, function(fn) {
     var engine = requires.underscore || (requires.underscore = require('underscore'));
     try {
+      for (var partial in options.partials) {
+        options.partials[partial] = engine.template(options.partials[partial]);
+      }
       var tmpl = cache(options) || cache(options, engine.template(str, null, options));
       fn(null, tmpl(options).replace(/\n$/, ''));
     } catch (err) {

diff --git a/test/consolidate.js b/test/consolidate.js
@@ -35,6 +35,7 @@ require('./shared').test('handlebars');
 require('./shared/partials').test('handlebars');
 require('./shared/helpers').test('handlebars');
 require('./shared').test('underscore');
+require('./shared/partials').test('underscore');
 require('./shared').test('lodash');
 require('./shared').test('qejs');
 require('./shared').test('walrus');

diff --git a/test/fixtures/underscore/partials.underscore b/test/fixtures/underscore/partials.underscore
@@ -0,0 +1 @@
+<p><%- user.name %></p><%= partials.partial(user) %>
diff --git a/test/fixtures/underscore/user_partial.underscore b/test/fixtures/underscore/user_partial.underscore
@@ -0,0 +1 @@
+<p><%- name %> from user_partial!</p>
diff --git a/test/shared/partials.js b/test/shared/partials.js
@@ -41,8 +41,22 @@ exports.test = function(name) {
           done();
         });
       });
-    }
-    else {
+    } else if (name == 'underscore') {
+      it('should support partials', function(done){
+        var path = 'test/fixtures/' + name + '/partials.' + name;
+        var locals = {
+          user: user,
+          partials: {
+            partial: 'user_partial'
+          }
+        };
+        cons[name](path, locals, function(err, html){
+          if (err) return done(err);
+          html.should.equal('<p>Tobi</p><p>Tobi from user_partial!</p>');
+          done();
+        });
+      });
+    } else {
       it('should support rendering a partial', function(done){
         var str = fs.readFileSync('test/fixtures/' + name + '/user_partial.' + name).toString();
         var locals = {