Added missing semicolon #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the time, we were just trying to get the linter set up, so exceptions were added to avoid modifying the code. I'm in favor of updating the code so the exceptions are not necessary. |
abetomo
approved these changes
Oct 21, 2018
This was referenced Feb 25, 2020
This was referenced Mar 12, 2020
This was referenced Mar 30, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There originally was a special ESLint exception for the one missing semicolon case:
https://github.com/tj/commander.js/blob/master/.eslintrc.json#L5
Other TJ projects like mocha always require semicolons, even in this case (
mochausessemistandardwhose rule is"semi": [2, "always"]Going back to the blame log, 4c9b4b8 is the commit that introduced it and the comment "customize linter to fit with style of project" suggests the original contributor @mojavelinux thought the missing semicolon was intentional.