Increase test coverage of executable spawn #1474
Merged
+64
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
We don't have much coverage of the executable launching details in the Jest coverage results, especially error cases.
Note: we do have multiple executable tests that aren't captured by the Jest coverage.
Solution
Add tests which mock
spawn
to allow injecting errors in more controlled fashion. These test failure paths rather than happy paths, are not end-to-end tests, but provide some coverage of existing behaviours.(I am still interested to see if we can include more of the existing tests in the Jest coverage results too.)
Increases Jest coverage from ~98% to ~99%.