-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage, including incrementNodeInspectorPort #1428
Merged
shadowspawn
merged 15 commits into
tj:release/7.x
from
shadowspawn:feature/increase-test-coverage
Jan 3, 2021
Merged
Increase test coverage, including incrementNodeInspectorPort #1428
shadowspawn
merged 15 commits into
tj:release/7.x
from
shadowspawn:feature/increase-test-coverage
Jan 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
changed the title
WIP: Increase test coverage
Increase test coverage, including incrementNodeInspectorPort
Jan 2, 2021
abetomo
approved these changes
Jan 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
shadowspawn
added
the
pending release
Merged into a branch for a future release, but not released yet
label
Jan 3, 2021
shadowspawn
removed
the
pending release
Merged into a branch for a future release, but not released yet
label
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Test coverage is less than 100%, partly due to hard to test areas of code.
Started at 92.25% for
% Stmts
.Solution
Increase test coverage by adding more of the special cases, and coverage of
incrementNodeInspectorPort
.Up to 97.59% for
% Stmts
.