git-style subcommands mess up argument order when using boolean flags

[mal]

index.js

var command = require('commander')

var cmd = command
  .command('hello', 'description')
  .parse(process.argv)

index-hello.js

var command = require('commander')

var cmd = command
  .option('--dry-run', 'prints actions, but takes none')
  .parse(process.argv)

console.log('opts', cmd.opts())
console.log('args', cmd.args)

output

$ node index.js hello 1 2 --dry-run 3 4 5 6
opts { dryRun: true }
args [ '1', '2', '4', '5', '6', '3' ]

Note how 3 has been shifted to the end. This really messes with you when working with subcommands that expect a specific argument ordering.

Found and tested against commander@2.9.0

[jmatsushita]

Ran into the same problem just now.

[nukelytide]

I can confirm this issue as well.

[stnever]

I can confirm this issue on commander@2.18.0 as well.

[shadowspawn]

This was reported again in #962 which has some good reproduction examples and discussion.

[shadowspawn]

Possible related, reported for action handler: #56 #75

[shadowspawn]

Reproduced related issue with action handler:

const program = require('commander');

program
  .command('sub <args...>')
  .option('-a')
  .action((args) => {
    console.log(args);
  })

program
  .parse(process.argv);

$ node badParse.js sub foo bar
[ 'foo', 'bar' ]
$ node badParse.js sub -a foo bar
[ 'foo', 'bar' ]
$ node badParse.js sub foo -a bar
[ 'bar', 'foo' ]

[shadowspawn]

Opened a PR to preserve argument order: #1138