-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #536
Update README.md #536
Conversation
Make it extra clear that some of these outputs only work if the `files` parameter has been specified. If `files` has not been specified, then they don't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing a fix, could you ensure that the test covers your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 12 potential problems in the proposed changes. Check the Files changed tab for more details.
@all-contributors please add @JoeOvo for docs |
I've put up a pull request to add @JoeOvo! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 12 potential problems in the proposed changes. Check the Files changed tab for more details.
Nicely done @JoeOvo |
Make it extra clear that some of these outputs only work if the
files
parameter has been specified. Iffiles
has not been specified, then they don't work.#393