Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[simd/jit]: Implement i16x8 comparison instructions #84

Merged
merged 1 commit into from
Jul 23, 2023
Merged

[simd/jit]: Implement i16x8 comparison instructions #84

merged 1 commit into from
Jul 23, 2023

Conversation

haoyu-zc
Copy link
Contributor

Tested by make -j && bin/spectest.x86-64-linux -tk -mode=spc test/regress/simd/simd_i16x8_cmp.bin.wast

titzer
titzer approved these changes Jul 23, 2023
View reviewed changes
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though would prefer to add expected failures to a file rather than commenting them out.

@titzer titzer merged commit 5c653a4 into titzer:master Jul 23, 2023
3 checks passed
@haoyu-zc
Copy link
Contributor Author

True that will be better! Will do so in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titzer titzer titzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoyu-zc @titzer