[BugFix] test_coverage and MKLThreads miniconda supported#2
Open
YLTsai0609 wants to merge 5 commits intotitoeb:masterfrom
Open
[BugFix] test_coverage and MKLThreads miniconda supported#2YLTsai0609 wants to merge 5 commits intotitoeb:masterfrom
YLTsai0609 wants to merge 5 commits intotitoeb:masterfrom
Conversation
…r better understanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @titoeb
Thanks for your great repo so that I can study RecWalk(2019) in Python.
Currently I found out there is only one python-based RecWalk implementation on github.
It's your repo! I'm glad that I have a chance to contribute.
I fix 1 bug and add miniconda support of MKLThreads.
1. test_coverage bug:
utils.pyline 7item_counts = np.zeros(Train.shape[0], dtype=np.int32)should beTrain.shape[1]Train.shape : (users, items).
I validate it by
example.ipynb. TheRecModel.NaiveBaselineshould give us coverage = 1.0 (which makes sense).2. MKLThreads miniconda supported.
I don't have
libmkl_rt.soforctypes.CDLLfunction inbase_model.pyline 191 and 193.After checked this
It turned out I installed miniconda instead of anaconda. miniconda use
libmkl_rt.dylibwhich is slower.But we can prevent miniconda user from the error.