Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[env] GitHub Actions 를 사용한 CI / CD 를 구축합니다. #53

Merged
merged 7 commits into from
Mar 12, 2020
Merged

[env] GitHub Actions 를 사용한 CI / CD 를 구축합니다. #53

merged 7 commits into from
Mar 12, 2020

Conversation

boxersb
Copy link

@boxersb boxersb commented Mar 12, 2020 •
edited
Loading

  • triple-frontend 의 ci, cd workflow 를 참조하여 eslint-config-triple 에도 적용합니다.
  • 기존의 GCP 빌드는 모두 제거하고, GHA 만으로 서비스합니다.
  • slack notifier 를 적용합니다. thanks to @zprime0920

@boxersb boxersb added this to the v1.0.0 milestone Mar 12, 2020
@boxersb boxersb requested a review from a team as a code owner March 12, 2020 03:07
inbeom
inbeom previously approved these changes Mar 12, 2020
View reviewed changes
yceffort
yceffort previously approved these changes Mar 12, 2020
View reviewed changes
Copy link

@yceffort yceffort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 레포에 eslint config triple 가져다 쓰고 싶네요 ㅋㅋㅋ

@boxersb
Copy link
Author

boxersb commented Mar 12, 2020

@yceffort 쓰시죠!!

@boxersb boxersb dismissed stale reviews from yceffort and inbeom via 94f7ebf March 12, 2020 04:19
@boxersb
Copy link
Author

boxersb commented Mar 12, 2020

몇가지만 테스트 해볼께요~ ㅎ

@boxersb
Copy link
Author

boxersb commented Mar 12, 2020

다시 심판해주세요!

@boxersb boxersb requested review from a team, inbeom and yceffort March 12, 2020 06:22
@boxersb boxersb requested a review from a team March 12, 2020 06:28
@boxersb
Copy link
Author

boxersb commented Mar 12, 2020

🙇

@boxersb boxersb merged commit 940aa17 into master Mar 12, 2020
@boxersb boxersb deleted the feature/github-actions branch March 12, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giwan-dev giwan-dev giwan-dev approved these changes

@inbeom inbeom inbeom approved these changes

@yceffort yceffort Awaiting requested review from yceffort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@boxersb @inbeom @giwan-dev @yceffort