Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies 를 정리하고, 의존 모듈 목록에 대한 문서를 보강합니다. #30

Merged
merged 6 commits into from
Sep 26, 2019
Merged

dependencies 를 정리하고, 의존 모듈 목록에 대한 문서를 보강합니다. #30

merged 6 commits into from
Sep 26, 2019

Conversation

boxersb
Copy link

@boxersb boxersb commented Sep 24, 2019 •
edited
Loading

Changes

  • 사용하지 않는 패키지들을 uninstall 합니다.
  • 프로젝트에서 dependencies 의 패키지들의 다른버전을 설치하지 않도록 문서 보강
    • README.md 에 의존 패키지 목록 공개 및 각 프로젝트에서 의존성 삭제 권고 문구 추가

@boxersb boxersb added this to the v0.3.0 milestone Sep 24, 2019
@boxersb boxersb requested review from inbeom, yceffort and a team September 24, 2019 00:35
yceffort
yceffort previously approved these changes Sep 24, 2019
View reviewed changes
@boxersb boxersb requested a review from a team September 24, 2019 00:39
inbeom
inbeom requested changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@inbeom inbeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전 약간 논의가 더 되면 좋겠사옵니다 ㅠㅠ dependencies에 넣고 싶어여

@inbeom
Copy link
Contributor

inbeom commented Sep 24, 2019

peer dependency를 등록해야 하는 이유가 triple-frontend 때문이라면 triple-frontend 쪽을 수정하는 게 맞을 것 같아여!

@boxersb
Copy link
Author

boxersb commented Sep 24, 2019

@inbeom dependencies 에서 빼는건 아닌데.. peerDependencies 기술 안하는게 더 좋다는 말씀이신가요?
triple-frontend 에서 만난 케이스에서 처럼 warning 을 노출해주려면 peerDependencies 에 버전 넣어 주는게 좋아보여서요.

@boxersb
Copy link
Author

boxersb commented Sep 24, 2019

@yceffort @inbeom 문서 수정해봤습니다. 확인 부탁드려요!

@boxersb
Copy link
Author

boxersb commented Sep 24, 2019

https://github.com/titicacadev/eslint-config-triple/blob/feature/peer-deps/README.md

@boxersb boxersb changed the title peerDependencies 를 추가합니다. dependencies 를 정리하고, 의존 모듈 목록에 대한 문서를 보강합니다. Sep 24, 2019
@yceffort
Copy link

확인했습니다. 감사합니다.
아직 PR올리지 않았지만, eslint 적용한 triple-frontend의 package.json 은 아래와 같이 설정해두었습니다.
titicacadev/triple-frontend@d122d04

@boxersb boxersb requested a review from a team September 24, 2019 23:31
@boxersb boxersb requested a review from a team September 24, 2019 23:36
@boxersb
Copy link
Author

boxersb commented Sep 24, 2019

🙇

inbeom
inbeom approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@inbeom inbeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@boxersb
Copy link
Author

boxersb commented Sep 26, 2019

🙇

@boxersb boxersb merged commit fe1e890 into master Sep 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/peer-deps branch September 26, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceffort yceffort yceffort approved these changes

@polysiya polysiya polysiya approved these changes

@inbeom inbeom inbeom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@boxersb @inbeom @yceffort @polysiya