Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable rule 'react/prop-types' #29

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Disable rule 'react/prop-types' #29

merged 1 commit into from
Sep 23, 2019

Conversation

boxersb
Copy link

@boxersb boxersb commented Sep 23, 2019

This closes #28

  • react/prop-types 를 off 합니다.

@boxersb boxersb added this to the v0.3.0 milestone Sep 23, 2019
@boxersb boxersb requested review from yceffort and a team September 23, 2019 06:30
@boxersb boxersb requested a review from a team September 23, 2019 06:34
appear
appear approved these changes Sep 23, 2019
View reviewed changes
Copy link

@appear appear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@boxersb
Copy link
Author

boxersb commented Sep 23, 2019

🙇

@boxersb boxersb merged commit 37e5be2 into master Sep 23, 2019
@boxersb boxersb deleted the feature/issue-28/react-prop-types branch September 23, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appear appear appear approved these changes

@inbeom inbeom inbeom approved these changes

@yceffort yceffort Awaiting requested review from yceffort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

[Rule] react/prop-types rule이 ts 에서도 필요할까?
3 participants
@boxersb @inbeom @appear