-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: update library tisfeng/OpenAI, enable to cancel OpenAI stream query #577
Conversation
Please review this PR. |
I'm testing with Built-in AI tranlsation, and from my web debugging proxy, the streaming didn't stop after I pressed stop? |
2024-06-06.17.23.08.mov |
ok, I will check it later. |
During the previous git merge, the crucial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it works. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #560
Now we can cancel OpenAI stream request when clicking stop button.
feat: implement cancellable in tisfeng/OpenAI#1