-
Notifications
You must be signed in to change notification settings - Fork 2
🆕 add a linux custom #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4ccb89c
to
1072e9a
Compare
…hash' into feature/add-linux-custom
@@ -1,14 +1,14 @@ | |||
ARG UBUNTU_24_04="ubuntu@sha256:04f510bf1f2528604dc2ff46b517dbdbb85c262d62eacc4aa4d3629783036096" | |||
FROM ${UBUNTU_24_04} | |||
|
|||
ENV TIPI_DISTRO_MODE=default | |||
ENV TIPI_DISTRO_MODE=all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we now have a full one, do we want to put a default toolchain file with useful compiler defaults ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"builders": [ | ||
{ | ||
"type": "docker", | ||
"image": "tipibuild/linux-custom-almalinux-95:{{cmake_re_source_hash}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets give them non-remote names, just like linux-custom-almalinux-95 wihtout tipibuild/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"builders": [ | ||
{ | ||
"type": "docker", | ||
"image": "tipibuild/tipi-linux-custom:{{cmake_re_source_hash}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here let's just name it linux-custom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
the purpose of the pr is to have a complete tipi environment for ubuntu 24.04 and an example of custom linux.