Skip to content

fix: clean up setTimeout on unmount in AdminEmails (apn-0d1oa.18) #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulvanbrenk merged 2 commits into from
Feb 26, 2026
+17 −3
Merged

fix: clean up setTimeout on unmount in AdminEmails (apn-0d1oa.18) #445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc25cf
fix: clean up setTimeout on unmount in AdminEmails (apn-0d1oa.18)
paulvanbrenk Feb 26, 2026
e77437b
Merge branch 'main' into merge/apn-0d1oa.18
paulvanbrenk Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions patchnotes-web/src/pages/AdminEmails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState, useEffect, useMemo } from 'react'
import { useState, useEffect, useMemo, useRef } from 'react'
import { useNavigate } from '@tanstack/react-router'
import { useQuery, useQueryClient } from '@tanstack/react-query'
import {
Expand Down Expand Up @@ -148,6 +148,18 @@ export function AdminEmails() {
message: string
} | null>(null)

const statusTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null)
const clearStatusTimeout = () => {
if (statusTimeoutRef.current) {
clearTimeout(statusTimeoutRef.current)
statusTimeoutRef.current = null
}
}

useEffect(() => {
return () => clearStatusTimeout()
}, [])

const queryClient = useQueryClient()
const updateMutation = useUpdateEmailTemplate({
mutation: {
Expand All @@ -160,11 +172,13 @@ export function AdminEmails() {
type: 'success',
message: 'Template saved successfully',
})
setTimeout(() => setSaveStatus(null), 3000)
clearStatusTimeout()
statusTimeoutRef.current = setTimeout(() => setSaveStatus(null), 3000)
},
onError: () => {
setSaveStatus({ type: 'error', message: 'Failed to save template' })
setTimeout(() => setSaveStatus(null), 5000)
clearStatusTimeout()
statusTimeoutRef.current = setTimeout(() => setSaveStatus(null), 5000)
},
},
})
Expand Down