fix: gate past_due IsPro on SubscriptionExpiresAt (apn-0d1oa.11)

PatchNotes.Data/User.cs

@@ -80,7 +80,7 @@ public class User : IHasCreatedAt, IHasUpdatedAt
     public bool IsPro =>
         SubscriptionStatus == "active" ||
         SubscriptionStatus == "trialing" ||
-        SubscriptionStatus == "past_due" ||
+        (SubscriptionStatus == "past_due" && SubscriptionExpiresAt > DateTimeOffset.UtcNow) ||
         (SubscriptionStatus == "canceled" && SubscriptionExpiresAt > DateTimeOffset.UtcNow);
 
     public ICollection<Watchlist> Watchlists { get; set; } = [];

PatchNotes.Tests/UserTests.cs

@@ -0,0 +1,69 @@
+using PatchNotes.Data;
+
+namespace PatchNotes.Tests;
+
+public class UserTests
+{
+    private static User MakeUser(string? status, DateTimeOffset? expiresAt = null) => new()
+    {
+        StytchUserId = "user-test",
+        SubscriptionStatus = status,
+        SubscriptionExpiresAt = expiresAt,
+    };
+
+    [Fact]
+    public void IsPro_Active_ReturnsTrue()
+    {
+        var user = MakeUser("active");
+        Assert.True(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_Trialing_ReturnsTrue()
+    {
+        var user = MakeUser("trialing");
+        Assert.True(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_Null_ReturnsFalse()
+    {
+        var user = MakeUser(null);
+        Assert.False(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_PastDue_WithFutureExpiry_ReturnsTrue()
+    {
+        var user = MakeUser("past_due", DateTimeOffset.UtcNow.AddDays(7));
+        Assert.True(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_PastDue_WithExpiredExpiry_ReturnsFalse()
+    {
+        var user = MakeUser("past_due", DateTimeOffset.UtcNow.AddDays(-1));
+        Assert.False(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_PastDue_WithNullExpiry_ReturnsFalse()
+    {
+        var user = MakeUser("past_due", null);
+        Assert.False(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_Canceled_WithFutureExpiry_ReturnsTrue()
+    {
+        var user = MakeUser("canceled", DateTimeOffset.UtcNow.AddDays(7));
+        Assert.True(user.IsPro);
+    }
+
+    [Fact]
+    public void IsPro_Canceled_WithExpiredExpiry_ReturnsFalse()
+    {
+        var user = MakeUser("canceled", DateTimeOffset.UtcNow.AddDays(-1));
+        Assert.False(user.IsPro);
+    }
+}