Skip to content

fix: filter IsSyncDisabled packages and track ConsecutiveFailures in sync (apn-0d1oa.12) #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulvanbrenk merged 1 commit into from
Feb 26, 2026
+9 −2
Merged

fix: filter IsSyncDisabled packages and track ConsecutiveFailures in sync (apn-0d1oa.12) #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PatchNotes.Sync.Core/SyncPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ private async Task ProduceAsync(
}

var db = scope.ServiceProvider.GetRequiredService<PatchNotesDbContext>();
var packages = await db.Packages.ToListAsync(ct);
var packages = await db.Packages.Where(p => !p.IsSyncDisabled).ToListAsync(ct);

_logger.LogInformation("Pipeline: syncing {Count} packages", packages.Count);

Expand Down
9 changes: 8 additions & 1 deletion PatchNotes.Sync.Core/SyncService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public async Task<SyncResult> SyncAllAsync(
CancellationToken cancellationToken = default)
{
var result = new SyncResult();
var packages = await _db.Packages.ToListAsync(cancellationToken);
var packages = await _db.Packages.Where(p => !p.IsSyncDisabled).ToListAsync(cancellationToken);

_logger.LogInformation("Starting sync for {Count} packages", packages.Count);

Expand Down Expand Up @@ -88,6 +88,11 @@ public async Task<SyncResult> SyncAllAsync(
entry.State = EntityState.Unchanged;
}
}

package.ConsecutiveFailures++;
package.LastFailureAt = DateTimeOffset.UtcNow;
package.LastFailureMessage = ex.Message.Length > 1024 ? ex.Message[..1024] : ex.Message;
await _db.SaveChangesAsync(cancellationToken);
}
}

Expand Down Expand Up @@ -239,6 +244,8 @@ public async Task<PackageSyncResult> SyncPackageAsync(
// completes successfully — no orphans if processing threw mid-loop
_db.Releases.AddRange(newReleases);
package.LastFetchedAt = fetchedAt;
package.ConsecutiveFailures = 0;
package.LastFailureMessage = null;
await _db.SaveChangesAsync(cancellationToken);

// Optionally include existing releases that are missing summaries
Expand Down