-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade React v19 and Tailwind v4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
hey rspress guys, any blocking points when migrating to Rspress 2.0-beta.5 :D
Could you provide some details or how can I help you bypass it? the |
Hey @SoonIter thanks for reaching out ❤️ I'm using Tailwind v4 for styling the content / component library - but due to the order of loaded styles it seems like the Buttons render without padding etc. When disabling the preflight styles for button: Let me know if I can help out in any way or provide more insights |
I judge from your screenshot that this issue should be the default style declaration of tailwind v4 in the Almost all component libraries have a so this issue should be checked to see if the tailwind v4 community has a solution. |
@SoonIter when looking into the generated Meaning styles in user space would always have lower priority than the reset? Not sure if it's an issue in rspress / Tailwind or in our configuration - one could argue that presets / resets / preflight should be on the first layer of priority / "base". Example: /* @import "tailwindcss"; */
@import "tailwindcss/theme.css" layer(theme);
@import "tailwindcss/preflight.css" layer(base);
@import "tailwindcss/utilities.css" layer(utilities); |
Looking at the |
Updating all dependencies - biggest ones are React v19 / Tailwind v4 / RAC + testing rspress v2 beta
Draft: