Skip to content

Split widgets #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Split widgets #45

wants to merge 18 commits into from

Conversation

CalebCourier
Copy link
Contributor

@CalebCourier CalebCourier commented Jun 15, 2023

Pull Request Type

  • Feature
  • Bug Fix
  • Patch
  • Breaking Refactor

Link to Notion Task or Github Issue

widget splitting

Summary of Feature

  1. Redefine Widgets in an MVC framework
    • Model contains the property definitions as well as toJson and base fromJson methods.
    • View contains the render function and its fromJson override.
    • Controller contains the getData function and its fromJson override
    • Simple Widgets where all the code is browser compliant can be defined in one file
  2. Update exports to automatically resolve frontend vs backend versions of the widgets
  3. Refactor classes for intuitive naming

Other details

While this is technically just a refactor, since it changes the exports and the way consuming widgets must inherit from the base classes and interfaces, we will be release this as a new major version. This way downstream projects that rely on installing via semver will not automatically update and break.

Dependencies

#41

@CalebCourier CalebCourier marked this pull request as ready for review June 19, 2023 21:33
@CalebCourier CalebCourier requested a review from a team June 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant