This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Fix for travis ci #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set go_import_path so forks of the project can benefit from Travis CI. Without this change there are some assumptions in the bootstrap script and also in the import of packages that won't be hold in a fork of the project and the tests will break.
Travis CI is in the process of changing all images from Precise to Trusty. See their announcement: https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming This would break how we install our dependencies. Note that we're using the Container based infrastructure (sudo: false). They plan to get rid of this combination (Precise + sudo: false) by Sep 5. Before that, we should try "sudo: required" or do the planned longterm change to run the tests within Docker images.
|
Woot woot. Nice! |
rafael
pushed a commit
that referenced
this pull request
Dec 11, 2019
* Converted sharded test from py to go Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
rafael
pushed a commit
that referenced
this pull request
Dec 11, 2019
* Converted sharded test from py to go Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com> Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change there are some assumptions in the bootstrap script and also in the
import of packages that won't be hold in a fork of the project and the tests
will break.