Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Sync with upstream 2019.03.19 branch #127

Merged
merged 292 commits into from
Mar 22, 2019
Merged
Changes from 1 commit
Commits
Show all changes
292 commits
Select commit Hold shift + click to select a range
2b03791
run bootstrap.sh on docker image if either vendor.json or bootstrap.s…
deepthi Feb 8, 2019
4a410e8
run govendor/bootstrap.sh on docker image as needed
deepthi Feb 8, 2019
98d1871
check for negative timeout
zklapow Feb 8, 2019
26cb613
add precommit hook
zklapow Feb 8, 2019
b5973f5
fix checkstyle hook
zklapow Feb 8, 2019
947817c
Bug fixes and cleanup
rafael Feb 8, 2019
83f0ef7
Update tests due to deprecated fields
rafael Feb 8, 2019
59c7f65
Update shard tests per refactor
rafael Feb 8, 2019
b4271d4
Update cell_info test due to refactor
rafael Feb 8, 2019
0612020
Update vtctld tests
rafael Feb 8, 2019
10df1d9
Updates tabletmanager tests
rafael Feb 9, 2019
6683b34
Fix some bugs that were surfaced by migrate served types tests
rafael Feb 9, 2019
06cae33
Eliminate flakiness for sync2.Batcher's unit test">
dweitzman Feb 4, 2019
1226179
Fix some typos in docs
JoeWrightss Feb 10, 2019
3d8b489
Support bool as column type
Feb 11, 2019
4d48a17
Fix wrangler tests. Mostly generate SrvKeyspace before running them
rafael Feb 11, 2019
31114e1
Fix vtctlient_test
rafael Feb 11, 2019
afe1e17
Re-add existent semantics where no cells provided means all cells
rafael Feb 11, 2019
cf405d7
Merge pull request #4594 from zklapow/zklapow-fix-channel-close
sougou Feb 12, 2019
9fd6690
Merge pull request #4605 from dweitzman/batcher_flakiness
sougou Feb 12, 2019
b37202e
Merge pull request #4606 from JoeWrightss/patch-1
sougou Feb 12, 2019
613bb78
Merge pull request #4609 from kuba--/bool-type
sougou Feb 12, 2019
950c316
use Get/PutObjectWithContext
deepthi Feb 12, 2019
4620508
Merge pull request #4598 from planetscale/ds-update-minio
sougou Feb 12, 2019
14a0387
Using the import ()
xichengliudui Feb 12, 2019
3b5e117
Fix bugs discovered by test in MigrateServedFrom
rafael Feb 12, 2019
4e163e8
Fix small errors in printing
xichengliudui Feb 12, 2019
7b51e94
Merge branch 'master' into zklapow-checkstyle
zklapow Feb 12, 2019
faf4628
Use the import () way
xichengliudui Feb 12, 2019
30c8a93
Use the import () way
xichengliudui Feb 12, 2019
7aa60d5
Use the import () way
xichengliudui Feb 12, 2019
b4bf807
fix violations
zklapow Feb 12, 2019
50209fc
Merge pull request #4599 from zklapow/zklapow-checkstyle
sougou Feb 12, 2019
91fb464
Merge pull request #4612 from xichengliudui/smallfix
sougou Feb 12, 2019
a569945
Merge pull request #4611 from xichengliudui/cleancode
sougou Feb 12, 2019
0a3f28b
Prefer predefined constants for mysql errors
dweitzman Feb 13, 2019
f94a71f
planbuilder: fix message inserts w/PassthroughDMLs
derekperkins Feb 13, 2019
0a2cfde
Merge pull request #4616 from nozzle/message-passthrough-dml
sougou Feb 13, 2019
9bbae99
Fix small errors in printing
longkb Feb 13, 2019
6338672
Merge pull request #4618 from longkb/fix_errors_in_printing
sougou Feb 13, 2019
940597e
Merge pull request #4617 from dweitzman/use_err_constants
sougou Feb 13, 2019
b6d5da2
Merge pull request #4595 from slanning/validate-replicating
sougou Feb 13, 2019
f8116b7
healthcheck: Cache regions in tablet_stats_cache
Feb 13, 2019
f49d9e0
Have a single method for region
Feb 13, 2019
7092679
Fix bugs in new srvKeyspace functions. Update tests to reflect new ch…
rafael Feb 13, 2019
64c7c61
Alloc cellRegions in test
Feb 13, 2019
68965cf
Update deprecated links in doc
Feb 14, 2019
4966399
Fix small errors
truongnh1992 Feb 14, 2019
a8dd181
Fix issue with bad dns zookeeper test
rafael Feb 14, 2019
eb7157b
Cleanup deprecated tests
rafael Feb 14, 2019
0b26cc0
project: add MAITAINERS.md
sougou Feb 15, 2019
48d1839
project: fix typo
sougou Feb 15, 2019
c4fdd1d
Merge pull request #4632 from planetscale/ss-maintainers
sougou Feb 15, 2019
d435735
Check for no scanners specified when createing consistent transactions
eeSeeGee Feb 15, 2019
19f6421
Merge pull request #4633 from eeSeeGee/young.20190215.check_for_no_sc…
sougou Feb 15, 2019
b370a31
Changed the comment to refer to "the mysql client" rather than vtctlc…
chrisrgithub Feb 15, 2019
dd8cb89
Merge pull request #4619 from HubSpot/cache_cell_regions
sougou Feb 15, 2019
5402ad0
Fix bugs in v2 sharding tests
rafael Feb 15, 2019
e4bb3b2
Merge pull request #4626 from truongnh1992/trivial-fix
deepthi Feb 15, 2019
4a31899
Merge pull request #4625 from xichengliudui/changeimportway03
deepthi Feb 15, 2019
0cf5466
Merge pull request #4623 from xichengliudui/changeimportway02
deepthi Feb 15, 2019
3e912e8
Merge pull request #4621 from xichengliudui/changeimportway
deepthi Feb 15, 2019
58431c4
Merge pull request #4620 from tuanvcw/update_deprecated_links
deepthi Feb 15, 2019
3864c05
Merge pull request #4634 from planetscale/example-helm-kmysql
deepthi Feb 15, 2019
0f1f26b
remove unsupported case from tests
deepthi Feb 15, 2019
1bfdb47
Resolve merge conflicts
deepthi Feb 15, 2019
5eda4cf
Fixes uncovered by integration tests
rafael Feb 16, 2019
1b0b81a
Adding copyright headers
truongnh1992 Feb 14, 2019
979cc79
More test fixes
rafael Feb 16, 2019
de49d79
Revert change to test now that underlying fix have been solved
rafael Feb 16, 2019
577ca97
vplayer: move query generation to TablePlan
sougou Feb 4, 2019
ccb2813
vplayer: add stats tracking
sougou Feb 4, 2019
150102e
Merge pull request #4627 from truongnh1992/copyright-header
deepthi Feb 16, 2019
e832f3f
Update deprecated links
huynq0911 Feb 16, 2019
1898eba
Change http to https for security links
huynq0911 Feb 16, 2019
121c967
Update deprecated links
huynq0911 Feb 16, 2019
bd0d967
Fix resharding test
rafael Feb 16, 2019
8694ae8
Fixed bug in srv_keyspace. Adds validations that were missed during m…
rafael Feb 16, 2019
3478e97
Adds utility function to check if query service disabled is set in a …
rafael Feb 16, 2019
f4cd023
Fixes for custom sharding
rafael Feb 16, 2019
d8afcf0
This test does not longer makes sense. We don't have cells in shards …
rafael Feb 16, 2019
b05e8cd
Remove deprecated assertion
rafael Feb 17, 2019
66c45d9
Merge pull request #4586 from planetscale/ss-vrepl
rafael Feb 17, 2019
b607d64
codegen: use strings.Builder instead of hack
sougou Feb 17, 2019
a4f9b0e
Merge pull request #4636 from huynq0911/fix_http_https
deepthi Feb 18, 2019
0924794
Merge pull request #4638 from planetscale/ss-strings-builder
sougou Feb 18, 2019
41767d8
vreplication: improved lag tracking
sougou Feb 13, 2019
e141810
Replace 404 links in doc
Feb 18, 2019
49a99c9
Fix bugs uncovered by tests and add some more tests to resharding int…
rafael Feb 18, 2019
9272b1c
Add ServedType for backwards compatiblilty
rafael Feb 19, 2019
83f313a
Merge pull request #4640 from tuanvcw/replace_404_links
rafael Feb 19, 2019
b00627e
Fixes test that broke due to adding back deprecated field
rafael Feb 19, 2019
1e4c740
introduce new timeout flag remote_operation_timeout. use it for short…
deepthi Feb 19, 2019
4309cd8
Fix some vtctld commands failing to return information to vtctlclient
dweitzman Feb 20, 2019
b7e5a98
Merge pull request #4647 from dweitzman/fix_wrangler_logging
dweitzman Feb 20, 2019
1e4c61e
Delete invalid picture links
xichengliudui Feb 21, 2019
c07b95b
update java/README.md
xichengliudui Feb 21, 2019
af38ff9
Remove the duplicated words
longkb Feb 21, 2019
7d3d747
Merge pull request #4648 from longkb/remove_deplicated_words
deepthi Feb 21, 2019
741182d
refactor backup code to allow us to plugin other backup engines
deepthi Feb 21, 2019
0c26ad4
Adding '#!/bin/bash' as a shebang line in env.sh
longkb Feb 20, 2019
29bf1d1
Add detail of the OS, kernel version in bug report
Feb 22, 2019
cc04498
Replacing 'HTTP' by 'HTTPS' for securing links
longkb Feb 22, 2019
b501f4a
Fixes #4652 - Chaining grpc interceptors
systay Feb 22, 2019
54498e3
Fix some misspells
JoeWrightss Feb 22, 2019
a6f5da6
Merge pull request #4550 from planetscale/ds-reparent-undo
sougou Feb 22, 2019
b2b3aeb
Merge pull request #4635 from planetscale/planetscale-ds-order-by-fail
sougou Feb 22, 2019
83ade5e
Merge pull request #4653 from planetscale/ds-backup-refactor
sougou Feb 22, 2019
2081082
Merge pull request #4655 from truongnh1992/issue_template
sougou Feb 22, 2019
37b6100
Merge pull request #4645 from longkb/adding_shebang_line
deepthi Feb 22, 2019
57bfc60
Merge pull request #4656 from longkb/replacing_http_by_https
sougou Feb 22, 2019
bce3d55
Merge pull request #4658 from JoeWrightss/patch-2
sougou Feb 22, 2019
eb440a9
Merge branch 'master' of https://github.com/jvaidya/vitess
jvaidya Feb 24, 2019
da65b0b
Merge branch 'master' of github.com:vitessio/vitess
jvaidya Feb 24, 2019
acdcfcc
SET @@SESSION.sql_mode is now ignored rather than erroring out
jvaidya Feb 24, 2019
6b90920
Merge pull request #4662 from jvaidya/session_sql_mode
sougou Feb 24, 2019
d0063cb
Trivial fix: Remove the redundant words
longkb Feb 25, 2019
3c9641b
Changing 'HTTP' to 'HTTPS' for securing vitess.io access
longkb Feb 25, 2019
12d7ead
Fix many typos in test code
Feb 25, 2019
46e8472
Fix many typos in doc
Feb 25, 2019
5b7b1a4
Update GitHub Workflow link
Feb 25, 2019
bf2e687
Refactor according to feedback
systay Feb 25, 2019
0ad6b78
Merge pull request #4667 from tuanvcw/update_github_workflow_link
sougou Feb 25, 2019
4afeec8
Merge pull request #4666 from tuanvcw/fixing_typos_doc
sougou Feb 25, 2019
0044154
Merge pull request #4665 from tuanvcw/fixing_typos
sougou Feb 25, 2019
9aca5b2
Merge pull request #4664 from longkb/update_https_to_vitess.io
sougou Feb 25, 2019
d4176b9
Merge pull request #4663 from longkb/remove_redundant_words
sougou Feb 25, 2019
44999b0
fix 404 not fount
xichengliudui Feb 26, 2019
2d0dbe5
Update the dead URL that links to 'guestbook-go'
longkb Feb 26, 2019
eb03e32
Remove any unnecessary highlighting
xichengliudui Feb 26, 2019
a2e43fe
Alphabetically sorted modules import
Feb 26, 2019
9cbaed3
Added unit tests
systay Feb 26, 2019
4a53b37
Merge pull request #4672 from truongnh1992/import-ordered
sougou Feb 26, 2019
834cafa
Merge pull request #4670 from longkb/fix_the_dead_url
sougou Feb 26, 2019
667eb19
Merge pull request #4657 from systay/fix4652
sougou Feb 26, 2019
261b341
Use jsonpb marshaling for vtctl's GetVSchema
dweitzman Feb 26, 2019
ec6a753
We should always time out health connections to a vttablet.
mpawliszyn Feb 26, 2019
69f128d
properly use sqlparser.String to quote reserved table names
demmer Feb 27, 2019
8316f8f
Merge pull request #4676 from dweitzman/getvschema_json_pb_format
dweitzman Feb 27, 2019
7fb5dce
Errors clean up
systay Feb 27, 2019
c6cae69
Use vterrors in the mysql package
systay Feb 27, 2019
f5638ab
Merge pull request #4681 from tinyspeck/vtexplain-support-escaped-tab…
sougou Feb 27, 2019
ca92ecd
fix mismatched parens
deepthi Feb 27, 2019
0034a99
InitShardMaster: make it more idempotent
sougou Feb 27, 2019
5d3c5b9
meetup details
sougou Feb 27, 2019
4e3faef
Merge pull request #4686 from planetscale/ss-fix-ism
sougou Feb 28, 2019
a70d6af
Optionally lint .sh files with "shellcheck" if it's installed
dweitzman Feb 27, 2019
66c3161
List available tests if test is not found
systay Feb 28, 2019
9c000b6
Typos
systay Feb 28, 2019
1a7ee9c
Fix some misspells in comment
JoeWrightss Feb 28, 2019
e113d2e
meetup details: add time
sougou Feb 28, 2019
ab02dcd
Merge pull request #4688 from planetscale/ss-meetup
sougou Feb 28, 2019
d8764de
Merge pull request #4680 from xichengliudui/update-java-readme
Feb 28, 2019
0a5c74c
Merge pull request #4693 from JoeWrightss/patch-3
sougou Feb 28, 2019
f7d1aa0
Merge pull request #4692 from systay/list-tests
sougou Feb 28, 2019
c74da0d
Merge pull request #4684 from dweitzman/shellcheck
sougou Feb 28, 2019
c07c1d5
Merge pull request #4683 from planetscale/ds-maintainers-typos
sougou Feb 28, 2019
eece355
Merge pull request #4679 from xichengliudui/fiximagefailure
sougou Feb 28, 2019
7afe66c
Merge pull request #4674 from mpawliszyn/mikepaw.not-serving-infinite…
sougou Feb 28, 2019
0d01465
Don't return cached heartbeat read when query service is down to avoi…
jschlather Feb 28, 2019
72689e8
allow backups on master tablet
deepthi Mar 3, 2019
66eebac
add failure case to test
deepthi Mar 3, 2019
6585831
Merge pull request #4556 from systay/errors
deepthi Mar 3, 2019
bec54fd
vplayer: address review comments
sougou Mar 3, 2019
31178f9
Merge pull request #4637 from planetscale/ss-vheart
sougou Mar 3, 2019
8510abf
vreplication: fix row move bug
sougou Feb 18, 2019
dc44178
Merge pull request #4702 from planetscale/ss-vrepl
sougou Mar 4, 2019
f6eeeba
Updating chromedriver dependencies and pinning chromium version
Mar 4, 2019
5b135f4
Merge pull request #4705 from planetscale/dk-update-bootstrap
sougou Mar 5, 2019
2268d56
Overhaul the Dockerfiles
Mar 5, 2019
b3674f2
Additional changes to explicitly state flavor
Mar 5, 2019
7eac276
Add tests to srv_keyspace
rafael Mar 5, 2019
075666b
Strictly check the structure of mysql static auth json config
Santiclause Mar 6, 2019
4041747
Merge pull request #4709 from Santiclause/vtaclcheck
sougou Mar 7, 2019
c0bc23c
Merge pull request #4706 from planetscale/dk-docker-file-refactor
sougou Mar 7, 2019
8913fcf
Merge pull request #4699 from planetscale/ds-allow-master-backup
sougou Mar 7, 2019
d0903f4
Add more tests. Deprecated method in favor of a more generic one.
rafael Mar 7, 2019
42a0d23
Adds tests for MigrateServedType
rafael Mar 7, 2019
60e5bc6
Fix some typos in docs
JoeWrightss Mar 7, 2019
9ba5c07
Adds test for multi shard migrate served types
rafael Mar 7, 2019
7e3c96e
staticcheck: mysql package
deepthi Feb 19, 2019
c858a37
cmd package
deepthi Feb 26, 2019
9e58dda
remove unused hook
deepthi Feb 26, 2019
2aa19cc
staticcheck: sqlparser package
deepthi Mar 3, 2019
306c29d
staticcheck: automation package
deepthi Mar 3, 2019
2e24040
staticcheck: binlog package
deepthi Mar 3, 2019
09e437c
staticcheck: dbconfigs package
deepthi Mar 3, 2019
872673a
staticcheck: env package
deepthi Mar 3, 2019
49f0161
staticcheck: hook package
deepthi Mar 3, 2019
26a9d7e
staticcheck: key package
deepthi Mar 3, 2019
deadd83
staticcheck: logutil package
deepthi Mar 3, 2019
6dd12c5
staticcheck: mysqlctl package
deepthi Mar 3, 2019
c3ea63e
staticcheck: schemamanager package
deepthi Mar 3, 2019
1a47e61
staticcheck: servenv package
deepthi Mar 3, 2019
73edfae
staticcheck: sqlannotation package
deepthi Mar 3, 2019
ca4ed90
staticcheck: srvtopo package
deepthi Mar 3, 2019
3d83330
staticcheck: tableacl package
deepthi Mar 3, 2019
41babfb
staticcheck: throttler package
deepthi Mar 3, 2019
5169d5b
staticcheck: topo package
deepthi Mar 3, 2019
9239a4a
staticcheck: vtaclcheck package
deepthi Mar 3, 2019
9b90784
staticcheck: vterrors package
deepthi Mar 3, 2019
5259280
staticcheck: vtgate package
deepthi Mar 3, 2019
d36a1bc
staticcheck: vttls package
deepthi Mar 3, 2019
48b7d47
staticcheck: topotools package
deepthi Mar 3, 2019
4608478
staticcheck: worker package
deepthi Mar 3, 2019
e5d8602
staticcheck: vtgate package
deepthi Mar 3, 2019
90c99d1
staticcheck: vttablet packages
deepthi Mar 4, 2019
0bf3d5b
staticcheck: handle errors from goroutines in tests correctly
deepthi Mar 4, 2019
a008747
staticcheck: unit test for readVariableInt bugfix
deepthi Mar 6, 2019
86474bb
staticcheck: packages/files missed during first pass
deepthi Mar 6, 2019
cc4030c
staticcheck: replace t.Fatal in goroutines with t.Error
deepthi Mar 6, 2019
40e6e27
staticcheck: fix test failures from changing error messages
deepthi Mar 7, 2019
13aa747
Merge branch 'upstream-master' into 4496-topo-serving-shards-refactor
rafael Mar 7, 2019
fb334bc
Merge pull request #4713 from JoeWrightss/patch-4
sougou Mar 7, 2019
227cd84
Error formatting fixes
rafael Mar 8, 2019
b5af454
Adds utility function to manipulate serving keyspace graph
rafael Mar 8, 2019
90a03e9
Adding pentest PDF
gedgar Mar 8, 2019
cd77571
Add security section to README
gedgar Mar 8, 2019
a49977e
Correcting link to pentest PDF
gedgar Mar 8, 2019
a592e87
Grammar tweak
gedgar Mar 8, 2019
f453e73
Merge pull request #4715 from planetscale/gary-update-readme
sougou Mar 8, 2019
9bd0a99
Merge pull request #4720 from xichengliudui/fixmdway
sougou Mar 12, 2019
447c36c
Merge pull request #4719 from xichengliudui/fixerrorlink
sougou Mar 12, 2019
d3d4ea4
Merge pull request #4689 from HubSpot/heartbeat-fix
sougou Mar 12, 2019
b9acd86
fixes from review
deepthi Mar 12, 2019
4efa9c1
Merge pull request #4644 from planetscale/ds-staticcheck
sougou Mar 12, 2019
dbf68ed
Merge branch 'master' of https://github.com/vitessio/vitess into 4496…
rafael Mar 14, 2019
410e20d
Updates per code review
rafael Mar 14, 2019
04ca16e
Chart.yaml: Update icon URL
gedgar Mar 16, 2019
4d89945
Merge pull request #4726 from planetscale/gary-fix-links
derekperkins Mar 16, 2019
ad1827f
vstreamer: remove hour, etc.
sougou Feb 24, 2019
3d91778
vplayer: use new new way to apply events
sougou Feb 24, 2019
e32cc4d
Fix go panic caused by unaligned atomic fields on certain architectures.
techninja1008 Mar 16, 2019
5ff205f
vtgate executor: route "show create table" to the user-provided or vs…
dweitzman Mar 18, 2019
318919b
Merge pull request #4703 from planetscale/ss-vrepl
sougou Mar 19, 2019
e1ed744
delete old website files, fix license in package.json
deepthi Mar 19, 2019
b7165dc
Merge pull request #4631 from tinyspeck/4496-topo-serving-shards-refa…
sougou Mar 19, 2019
94ab760
servenv: add new keepalive flag to grpc server
derekperkins Mar 19, 2019
ae47a53
Merge pull request #4737 from nozzle/grpc-keepalive-flag
sougou Mar 19, 2019
8ec6f2e
Merge pull request #4735 from planetscale/ds-license-fixes
sougou Mar 19, 2019
20bd2bb
Merge pull request #4732 from dweitzman/show_create
sougou Mar 19, 2019
5d425ed
Merge pull request #4729 from techninja1008/master
sougou Mar 19, 2019
20b59bb
Single round trip commit on BatchExecute
rafael Mar 14, 2019
55dc4aa
Fix flaky test
rafael Mar 22, 2019
4937f39
vindexes.BuildVSchema: prevent one bad sequence from breaking all oth…
dweitzman Mar 21, 2019
31482b7
Merge pull request #4744 from tinyspeck/fix-flaky-test
sougou Mar 22, 2019
7a201e3
Merge pull request #4743 from dweitzman/isolate_bad_seq_impact
dweitzman Mar 22, 2019
dcbeedd
Add Pinterest to ADOPTERS.md
dweitzman Mar 21, 2019
56c2a93
Merge pull request #4739 from tinyspeck/autocommit-batch-execute
demmer Mar 22, 2019
ec48bbd
Merge pull request #4742 from dweitzman/adopters
rafael Mar 22, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More test fixes
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
  • Loading branch information
rafael committed Feb 16, 2019
commit 979cc79b9c82d973985abd6c68816240d9c9f36b
21 changes: 16 additions & 5 deletions go/vt/wrangler/keyspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,22 @@ func (wr *Wrangler) masterMigrateServedType(ctx context.Context, keyspace string
return err
}

// Update srvKeyspace now
if err = wr.ts.MigrateServedType(ctx, keyspace, destinationShards, sourceShards, topodatapb.TabletType_MASTER, nil); err != nil {
return err
}

// Make sure that from now on source shards have IsMasterServing set to false
for _, si := range sourceShards {
_, err := wr.ts.UpdateShardFields(ctx, si.Keyspace(), si.ShardName(), func(si *topo.ShardInfo) error {
si.IsMasterServing = false
return nil
})
if err != nil {
return err
}
}

if reverseReplication {
if err := wr.startReverseReplication(ctx, sourceShards); err != nil {
return err
Expand All @@ -631,11 +647,6 @@ func (wr *Wrangler) masterMigrateServedType(ctx context.Context, keyspace string
}
}

// Update srvKeyspace now
if err = wr.ts.MigrateServedType(ctx, keyspace, destinationShards, sourceShards, topodatapb.TabletType_MASTER, nil); err != nil {
return err
}

event.DispatchUpdate(ev, "finished")
return nil
}
Expand Down