Error when using addRow after setting an index with Ids and sortKey

[pottedmeat]

Describe the bug

I tracked down this error I was running into and was able to isolate it and create a test case. It only happens when a row is added after defining an index with both a multi-id slice and a sort key—basically a scenario where force is false. This:

1. adds the sliceId array to unsortedSlices.
2. Attempts to use the sliceId array as a key in a mapGet call.

The force: true path just above doesn't have the same problem as it iterators over the keys in index which are individual slice IDs.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

import { createStore } from 'tinybase';
import { createIndexes } from 'tinybase/indexes';

const store = createStore();
const indexes = createIndexes(store);

indexes.setIndexDefinition(
    'byLetter',
    'names',
    (getCell) => getCell('name').toLowerCase().split(''),
    (getCell) => getCell('name').toLowerCase().split('')[0],
);

store.addRow('names', { name: 'John' });

Expected behavior

Index is added successfully without throwing an error.

Screenshots or Videos

            const sliceArray = [...mapGet(index, sliceId)];
                                   ^

TypeError: mapGet is not a function or its return value is not iterable
    at file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/indexes/index.js:453:36
    at Set.forEach (<anonymous>)
    at collForEach (file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/indexes/index.js:43:41)
    at file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/indexes/index.js:446:11
    at processTable (file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/indexes/index.js:182:7)
    at Array.<anonymous> (file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/indexes/index.js:216:45)
    at file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/index.js:473:36
    at Set.forEach (<anonymous>)
    at collForEach (file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/index.js:146:41)
    at file:///Users/neil/Products/Inkdex/index-bug/node_modules/tinybase/index.js:472:7

Platform

• Version: 5.4.8

Additional context

If you put the addRow before setIndexDefinition there is no error and it works as expected.

[jamesgpearce]

This is an epic bug report. Thank you so much! - and I have a hunch that it should be an easy fix... once I can get to a computer. Thanks again.

[pottedmeat]

Were you able to make any progress on this?

[jamesgpearce]

Yep, can repro in a test case (it also fails with setRow, not just addRow). Working on it now!

[jamesgpearce]

OK, this test case was failing with that error:

test('Sorted multi-slice index does not error', () => {
  const store = createStore();
  const indexes = createIndexes(store);

  indexes.setIndexDefinition(
    'i1',
    't1',
    (getCell) => (getCell('c1') + '').split(''),
    (getCell) => (getCell('c1') + '').split('')[0],
  );

  store.setCell('t1', 'r1', 'c1', 'abc');
  store.setCell('t1', 'r2', 'c1', 'abc');
  store.setCell('t1', 'r1', 'c1', 'ab');
  expect(store.getTables()).toEqual({t1: {r1: {c1: 'ab'}, r2: {c1: 'abc'}}});
  expect(getIndexesObject(indexes)).toEqual({
    i1: {a: ['r1', 'r2'], b: ['r1', 'r2'], c: ['r2']},
  });
});

...and now doesn't! New release coming.

[jamesgpearce]

Check out v6.0.4 to check I got it for you.

[pottedmeat]

Works for me! Thanks so much.