Skip to content

@storybook/storybook-deployer leaked into dependencies #479

Closed

Description

What is the current behavior?
@tinymce/tinymce-react contains @storybook/storybook-deployer in the dependencies in package.json, which cascades to all configurations consuming @tinymce/tinymce-react@4.3.1

Steps to reproduce

npm install @tinymce/tinymce-react@4.3.1

What is the expected behavior?
Package forces the consuming application to only download the packages that are used during runtime when using npm i

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE or tinymce-react?
Version: 4.3.1
PR: #478
In previous versions the dependency array only contained prop-types and tinymce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    GitHubIssues that have been added to our internal issue tracker.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions