Skip to content

all: update WASI 0.2 bindings #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 18, 2025

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Mar 16, 2025

  • Update to go.bytecodealliance.org@v0.6.2
  • Update package cm to go.bytecodealliance.org/cm@v0.2.2
  • Regenerate WASI 0.2 bindings in internal/wasi

Full changelog: https://github.com/bytecodealliance/go-modules/blob/main/CHANGELOG.md

@ydnar ydnar self-assigned this Mar 16, 2025
@ydnar ydnar requested a review from dgryski March 16, 2025 05:03
@b0ch3nski
Copy link
Contributor

Somehow the regeneration adds an executable bit on the files which is not needed I think?

@ydnar
Copy link
Contributor Author

ydnar commented Mar 16, 2025

Somehow the regeneration adds an executable bit on the files which is not needed I think?

Yes, odd. Let me look.

@ydnar
Copy link
Contributor Author

ydnar commented Mar 16, 2025

Thanks! Fixed here: bytecodealliance/go-modules#316

This is a temporary fix until cm@v0.2.2 is released, and package internal/cm and internal/wasi can be regenerated.

See tinygo-org#4810 for more information.
@ydnar ydnar marked this pull request as draft March 17, 2025 00:45
@ydnar ydnar marked this pull request as ready for review March 17, 2025 03:08
@deadprogram
Copy link
Member

@ydnar perhaps you want to rebase this against the latest dev for testing?

@deadprogram
Copy link
Member

Hard for me to evaluate this PR except for "the tests are passing". From that point of view, we can merge now.

@ydnar
Copy link
Contributor Author

ydnar commented Mar 18, 2025

Key changes include:

  1. Migration to new Go package path : go.bytecodealliance.org
  2. Removed unnecessary generated .wit file in internal/wasi
  3. Bug fixes and improvements

Full changelog: https://github.com/bytecodealliance/go-modules/blob/main/CHANGELOG.md

@deadprogram
Copy link
Member

Now merging, thank you!

@deadprogram deadprogram merged commit e5a8d69 into tinygo-org:dev Mar 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants