Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: use wasm-tools-go@v0.2.0 #4456

Merged
merged 3 commits into from
Sep 6, 2024
Merged

all: use wasm-tools-go@v0.2.0 #4456

merged 3 commits into from
Sep 6, 2024

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Sep 5, 2024

@ydnar ydnar requested a review from dgryski September 5, 2024 18:32
dgryski
dgryski approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved unless the go.mod line is wrong..

internal/wasm-tools/go.mod Outdated Show resolved Hide resolved
dgryski
dgryski approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deadprogram
Copy link
Member

Thank you for updating @ydnar and to @dgryski for review. Now merging.

@deadprogram deadprogram merged commit e13d4ba into tinygo-org:dev Sep 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgryski dgryski dgryski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydnar @deadprogram @dgryski