WIP:riscv64-qemu target #3545
Open
WIP:riscv64-qemu target #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rminnich
commented
Mar 13, 2023
•
rminnich
commented
aykevl
reviewed
Mar 13, 2023
There was a problem hiding this comment.
Early (non-final) review:
- Please add
riscv64-qemuto builder/builder_test.go and run the test. - Please add at least a smoke test for this.
- Are you sure the compiler matches with the code? Because you're compiling with a LLVM 14 based TinyGo version and the error it gives usually indicates a version mismatch.
|
thanks, that was fast!, will add those things. |
rminnich
force-pushed
the
riscv64-qemu
branch
2 times, most recently
from
ac55424
to
3ec17b4
Compare
tinygo build -target riscv64-qemu -monitor . many of these: tinygo:ld.lld: error: /home/rminnich/.cache/tinygo/thinlto/llvmcache-933570AB9628376F0C2EAD9666A92A793D143BE9:\ (function (reflect.Value).Complex: .text.(reflect.Value).Complex+0x76): relocation R_RISCV_HI20 out of range: \ 524291 is not in [-524288, 524287]; references reflect$string.170 >>> referenced by value.go:0 (/home/rminnich/tinygo/src/reflect/value.go:0) >>> defined in /home/rminnich/.cache/tinygo/thinlto/llvmcache-933570AB9628376F0C2EAD9666A92A793D143BE9 what's odd is that it the number is 524291 is 0x80003 I had to dump the llvm output to see the 0xffff_ffff bits. Signed-off-by: Ronald G. Minnich <rminnich@google.com>
aykevl
reviewed
Apr 29, 2023
| "build-tags": ["virt", "qemu"], | ||
| "default-stack-size": 4096, | ||
| "linkerscript": "targets/riscv64-qemu.ld", | ||
| "emulator": "qemu-system-riscv32 -machine virt -nographic -bios none -kernel {}" |
There was a problem hiding this comment.
qemu-system-riscv32? That doesn't look right.
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "inherits": ["riscv64"], | |||
| "features": "+a,+c,+m,-relax,-save-restore", | |||
There was a problem hiding this comment.
These don't seem quite right, the test is complaining about it:
builder_test.go:145: target has LLVM features
"+a,+c,+m,-relax,-save-restore"
but Clang makes it
"+64bit,+a,+c,+d,+f,+m,-relax,-save-restore"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.