machine/rp2040: implement i2c #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
reviewed
Jul 30, 2021
deadprogram
reviewed
Jul 30, 2021
deadprogram
reviewed
Jul 30, 2021
deadprogram
reviewed
Jul 30, 2021
|
The I2C pin definitions are needed here just like in the SPI PR, please. |
machine/rp2040: add i2c apply @deadprogram's suggestions. thanks! consolidate pin naming fix up i2c configuration forgot about featherRP2040 add i2c pins for nano connect add i2c variable handles
|
@deadprogram had to rollback merge to squash commits. Should be A-OK now. |
|
Tested with my SSD1306 display and worked perfectly. Thanks @soypat now squash/merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look. Tested it with mpu6050 driver. Solves #1989.