Skip to content

Implement reflect.New#1787

Merged
deadprogram merged 1 commit into
devfrom
reflect-new
Apr 12, 2021
Merged

Implement reflect.New#1787
deadprogram merged 1 commit into
devfrom
reflect-new

Conversation

@aykevl

@aykevl aykevl commented Apr 11, 2021

Copy link
Copy Markdown
Member

This is very important for some use cases, for example for Vecty.

CC @slimsag @marwan-at-work

This PR also includes commits from #1763, I'll rebase this PR once #1763 gets merged.

@aykevl

aykevl commented Apr 11, 2021

Copy link
Copy Markdown
Member Author

Note that this change increases code size for code that uses reflection, but honestly I don't see an easy way around that (while also implementing reflect.New).

This is very important for some use cases, for example for Vecty.
@aykevl

aykevl commented Apr 12, 2021

Copy link
Copy Markdown
Member Author

Rebased to fix merge conflicts.

@deadprogram

Copy link
Copy Markdown
Member

🎉 amazing! Now merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants