Fix gps time calculation #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rhykw thanks for working on this. You probably want to base it off of the https://github.com/tinygo-org/drivers/blob/release/CONTRIBUTING.md#how-to-use-our-github-repository |
rhykw
force-pushed
the
fix-gps-time-calculation
branch
from
cde8fd6 to
d6e9f4b
Compare
|
@deadprogram |
|
Thank you for the correction @rhykw now squash/merging. |
deadprogram
pushed a commit
that referenced
this pull request
Sep 16, 2025
* Change test case to match the date patterns where the bug reproduces * Fix RMC date and time calculation
deadprogram
pushed a commit
that referenced
this pull request
Sep 20, 2025
* Change test case to match the date patterns where the bug reproduces * Fix RMC date and time calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #784
The Parse() function in the gps package incorrectly calculates dates on or after June 1st, resulting in a timestamp that is one day earlier than the correct date.