add regmap package to facilitate heapless driver development #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deadprogram Sorry bout #768, this one should be OK |
|
@soypat what do you think about adding some test coverage? |
|
@soypat your thoughts? |
|
I'm not sure of the value of adding tests. These are meant to be used by drivers which are themselves tested on the hardware. Same logic goes for this package. I won't trust it works, even with tests, until I see hardware using it. I say add it and let users use it and get some real testing going. It is an internal package so no risk of adding it. |
|
Can we merge this? Would like to have it for a class I'll be teaching |
|
Now merging due to popular demand. 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing the botched #768 PR