Skip to content

Use QUOTE_MINIMAL everywhere #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clickhouse_mysql/writer/csvwriter.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def delete_row(self, event_or_events):
if self.dst_table is None:
self.dst_table = event.table

self.writer = csv.DictWriter(self.file, fieldnames=self.fieldnames, quoting=csv.QUOTE_ALL)
self.writer = csv.DictWriter(self.file, fieldnames=self.fieldnames, quoting=csv.QUOTE_MINIMAL)
if not self.header_written:
self.writer.writeheader()

Expand Down Expand Up @@ -253,7 +253,7 @@ def update(self, event_or_events):
if self.dst_table is None:
self.dst_table = event.table

self.writer = csv.DictWriter(self.file, fieldnames=self.fieldnames, quoting=csv.QUOTE_ALL)
self.writer = csv.DictWriter(self.file, fieldnames=self.fieldnames, quoting=csv.QUOTE_MINIMAL)
if not self.header_written:
self.writer.writeheader()

Expand Down